octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch to Octave shutdown procedures


From: Michael Goffioul
Subject: Re: Patch to Octave shutdown procedures
Date: Wed, 20 May 2009 10:08:28 +0100

On Wed, May 20, 2009 at 9:06 AM, Jaroslav Hajek <address@hidden> wrote:
> I committed the following patch:
> http://hg.savannah.gnu.org/hgweb/octave/rev/ee7cf4d963f3
>
> summary:
> quit() now raises an octave_quit_exception, carrying the exit status.
> this is handled in main_loop and a couple of other functions.
> octave_exit pointer is declared and points to ::exit at startup. it
> may be overriden by user code or even NULL.
>
> also, main_loop et al. now perform unwind_protect_cleanup actions when
> quit() is called. It seems reasonable to do so - anyone disagrees?

Please tag octave_exit with OCTINTERP_API, to make it MSVC user-friendly.
I'm not sure about the syntax in that particular case (function type),
I think it
should be

extern OCTINTERP_API void (*octave_exit) (int);

But what will definitely work (besides the typos) is

typedef void(*octave_exit_t)(int);
extern OCTINTERP_API octave_exit_t octave_exit;

Michael.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]