Re: bug in oct-cmplx.h?

[Thorsten Meyer]

John W. Eaton wrote:
> On 15-Sep-2009, Thorsten Meyer wrote:
>
> | I always thought that ./config.status --recheck did the same as
> | ./configure (only that it saved me retyping the detailed configure
> | options).  Apparently, this is not (always) the case. Can you explain?
>
> Read the description of the --recheck option in the autoconf manual.
> I don't think it does what you expect.  I think this is an autoconf
> issue, but perhaps we could have better integration of autoconf and
> Make, so that things are updated correctly and automatically when
> there are changes to the configure scripts.  That we generally need to
> run autogen.sh and configure when things change doesn't bother me too
> much, so I'm unlikely to make changes, but I would of course consider
> patches.
>   
I have been using the make target "configfiles", that actually tries to
update the configuration files correctly. Only it's broken for config.h
(I did not realize that config.h is generated by config.status just like
the Makefiles when I implemented it).

Included is a simple patch that should fix the "configfiles" target wrt
config.h.

Is it ok to push it?

Thanks

Thorsten

# HG changeset patch
# User Thorsten Meyer <address@hidden>
# Date 1253030928 -7200
# Node ID 445729c127cc46078aa37b336d3feaf60bb9453b
# Parent  85dd3a2c9355dc4cf05d36fa3be0fea6bdafa4e9
Add config.h to the list of config files regenerated by the make target 
'configfiles'

diff -r 85dd3a2c9355 -r 445729c127cc ChangeLog
--- a/ChangeLog Tue Sep 15 10:00:53 2009 +0200
+++ b/ChangeLog Tue Sep 15 18:08:48 2009 +0200
@@ -0,0 +1,5 @@
+2009-09-15  Thorsten Meyer  <address@hidden>
+
+       * octMakefile.in (all): add config.h to the list of configuration
+       files to be updated by the make target configure.
+
diff -r 85dd3a2c9355 -r 445729c127cc octMakefile.in
--- a/octMakefile.in    Tue Sep 15 10:00:53 2009 +0200
+++ b/octMakefile.in    Tue Sep 15 18:08:48 2009 +0200
@@ -74,7 +74,7 @@
 SHELL_SCRIPTS = octave-bug$(SCRIPTS_EXE_SUFFIX) 
octave-config$(SCRIPTS_EXE_SUFFIX) \
                mkoctfile$(SCRIPTS_EXE_SUFFIX)  run-octave
 
-CONFIG_FILES = @ac_config_files@
+CONFIG_FILES = config.h @ac_config_files@
 
 M4_FILES = $(wildcard *.m4)