Re: [patch] Re: cannot generate a compliable builtins.cc

[Rob Mahurin]

On Tue, Dec 22, 2009 at 04:51:53PM -0500, Rob Mahurin wrote:
> On Sat, Dec 19, 2009 at 10:42:01PM -0500, Rob Mahurin wrote:
> > It turns out the /usr/bin/sed shipped with OSX 10.5 does not handle
> > regular expressions like (this|that) :
> > 
> >     $ echo lex.ll | sed 's,.*/,,; s/\.\(cc\|yy\|ll\)$/.df/';
> >     lex.ll
> >     $ echo lex.ll | gsed 's,.*/,,; s/\.\(cc\|yy\|ll\)$/.df/';
> >     lex.df
> > 
> > This meant that find-defun-files.sh a partially wrong list of files to
> > mkbuiltins, and builtins.cc contained dozens of complete source files.
> > 
> > An appropriate patch to submit would be a configure test that checks
> > whether sed works.  A sexier patch would be to write
> > find-defun-files.sh.in and allow "./configure SED=gsed".  I don't know
> > how to do either of these things.
> 
> The configure script was already checking whether sed had this defect.
> The attached patch changes src/find-defun-files.sh to use $SED as found by
> configure.

The previous patch was wrong: it called $SED rather than setting $SED.
_This_ attached patch changes src/find-defun-files.sh to use $SED as
found by configure.  How embarrassing.

Cheers,
Rob

use_config_sed.patch
Description: Text document