Re: build trouble on MacOS 10.5 [patch]

[John W. Eaton]

On 22-Dec-2009, Rob Mahurin wrote:

| On Tue, Dec 22, 2009 at 09:16:30AM -0500, Ben Abbott wrote:
| > Good news, I'm able to build with all libs except for Apple's Carbon and 
OpenGL frameworks.
| > 
| >   $ ./configure --prefix=/sw --infodir=${prefix}/share/info 
--mandir=${prefix}/share/man --libexecdir=${prefix}/lib 
--with-blas=-Wl,-framework -Wl,vecLib --without-framework-carbon 
--without-framework-opengl
| > 
| > Make check only has two failures.
| > 
| > Summary:
| > 
| >   PASS   5659
| >   FAIL      2
| > 
| > Once, I can build everything I need to be fully functional, I'll
| > look into the test failures.
| 
| I see the same, with a fresh checkout of revision 10014:cb98128649e9.
| 
|       $ ./configure 
|       CC=gcc-mp-4.3 CXX=g++-mp-4.3 F77=gfortran-mp-4.3 
LDFLAGS=-L/opt/local/lib
|       --without-framework-opengl --without-framework-carbon
| 
|         PASS   5507
|         FAIL      2
| 
| I needed the patch attached to include <config.h> before any
| <string.h>.  Is this harmless on other systems?  Is it safe to assume
| that anyone doing "make -C src lex.cc" will have a running perl, or is
| some other magic necessary?  jwe had a less ugly suggestion.
| 
| Cheers,
| Rob
| 
| ----------------------------------------------------------------------
| diff -r 6918d86add73 liboctave/ChangeLog
| --- a/liboctave/ChangeLog     Fri Dec 18 13:26:05 2009 -0500
| +++ b/liboctave/ChangeLog     Sat Dec 19 12:56:16 2009 -0500
| @@ -1,3 +1,7 @@
| +2009-12-19  Rob Mahurin  <address@hidden>
| +
| +     * md5.c: Include <config.h> before <string.h>.
| +     
|  2009-12-17  John W. Eaton  <address@hidden>
|  
|       * glob-match.h, glob-match.cc (glob_match::glob_internal):
| diff -r 6918d86add73 liboctave/md5.c
| --- a/liboctave/md5.c Fri Dec 18 13:26:05 2009 -0500
| +++ b/liboctave/md5.c Sat Dec 19 12:56:16 2009 -0500
| @@ -51,6 +51,9 @@
|    1999-05-03 lpd Original version.
|   */
|  
| +#ifdef HAVE_CONFIG_H                                                         
 
| +#include <config.h>                                                          
 
| +#endif                                                                       
 
|  #include "md5.h"
|  #include <string.h>
|  

I checked in the following change instead so that we are now using the
md5 functions from gnulib.

  http://hg.savannah.gnu.org/hgweb/octave/rev/acd5e9df38f8

jwe