Re: new gnulib problem when building liboctave

[Ben Abbott]

On Jan 21, 2010, at 5:39 AM, Michael Goffioul wrote:

> On Thu, Jan 21, 2010 at 10:33 AM, Ben Abbott <address@hidden> wrote:
>> With the recent changes, I now see
>> 
>> libtool: compile:  g++-4.2 -DHAVE_CONFIG_H -I. -I.. -I/sw/lib/flex/include 
>> -I/sw/include -O1 -m32 -I/sw/include/freetype2 -I/sw/include/qhull 
>> -I/usr/include -I/sw/include -I../libgnu -I../libgnu -I../libcruft/misc 
>> -I/sw/lib/flex/include -I/sw/include -O1 -m32 -I/sw/include/freetype2 
>> -I/sw/include/qhull -I/usr/include -I/sw/include -I/sw/include -O1 -m32 
>> -D_THREAD_SAFE -D_REENTRANT -DHAVE_CONFIG_H -I/sw/include/freetype2 
>> -I/sw/include -I/usr/X11/include -Wall -W -Wshadow -Wold-style-cast -Wformat 
>> -I/sw/include -O1 -m32 -D_THREAD_SAFE -D_REENTRANT -D_THREAD_SAFE 
>> -I/sw/include -O1 -m32 -D_THREAD_SAFE -D_REENTRANT -MT 
>> liboctave_la-file-ops.lo -MD -MP -MF .deps/liboctave_la-file-ops.Tpo -c 
>> file-ops.cc  -fno-common -DPIC -o .libs/liboctave_la-file-ops.o
>> file-ops.cc:40:21: error: pathmax.h: No such file or directory
>> 
>> If I manually compile with the second "-I../libgnu" replaced by 
>> "-I../gnulib/lib", there is no error.
>> 
>> g++-4.2 -DHAVE_CONFIG_H -I. -I.. -I/sw/lib/flex/include -I/sw/include -O1 
>> -m32 -I/sw/include/freetype2 -I/sw/include/qhull -I/usr/include 
>> -I/sw/include -I../libgnu -I../gnulib/lib -I../libcruft/misc 
>> -I/sw/lib/flex/include -I/sw/include -O1 -m32 -I/sw/include/freetype2 
>> -I/sw/include/qhull -I/usr/include -I/sw/include -I/sw/include -O1 -m32 
>> -D_THREAD_SAFE -D_REENTRANT -DHAVE_CONFIG_H -I/sw/include/freetype2 
>> -I/sw/include -I/usr/X11/include -Wall -W -Wshadow -Wold-style-cast -Wformat 
>> -I/sw/include -O1 -m32 -D_THREAD_SAFE -D_REENTRANT -D_THREAD_SAFE 
>> -I/sw/include -O1 -m32 -D_THREAD_SAFE -D_REENTRANT -MT 
>> liboctave_la-file-ops.lo -MD -MP -MF .deps/liboctave_la-file-ops.Tpo -c 
>> file-ops.cc  -fno-common -DPIC -o .libs/liboctave_la-file-ops.o
>> 
>> I'd venture to guess that the changeset below should also haved added 
>> "-I../gnulib/lib" to AM_CPPFLAGS in Makefile.am?
>> 
>>        http://hg.savannah.gnu.org/hgweb/octave/rev/326746625a51
>> 
>> Something like what is below?
>> 
>>  24 AM_CPPFLAGS = \
>>  25   @CPPFLAGS@ -I../libgnu -I$(top_srcdir)/libgnu \
>>  26   -I$(top_srcdir)/libcruft/misc -I../gnulib/lib 
>> -I$(top_srcdir)/gnulib/lib
>> 
>> If I make that change to my sources, all appears to work. However, I don't 
>> know if this is the right thing to do.
> 
> I guess the more correct fix is to add pathmax module to bootstrap.conf.
> 
> Michael.

pathmax has already been added to the list of gnulib_modules in bootstrap.conf.

Should that be all that is needed to add ../gnulib/lib to the include path? If 
so, perhaps this is another feature of MacOS X?

Ben