octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: compiling development sources


From: John W. Eaton
Subject: Re: compiling development sources
Date: Wed, 10 Feb 2010 16:44:54 -0500

On 10-Feb-2010, Jaroslav Hajek wrote:

| I checked in the following patch:
| http://hg.savannah.gnu.org/hgweb/octave/rev/2ceae0b40515
| 
| hope this solves the problem for you.

The last hunk of that change is

@@ -530,7 +537,13 @@
    3.39            if (btyp != btyp_unknown)
    3.40              dispatch_type = btyp_class_name[btyp];
    3.41            else
    3.42 -            builtin_class = false;
    3.43 +            {
    3.44 +              // Basically, this should never happen if all values 
are defined.
    3.45 +              // If not, that's an internal inconsistency.
    3.46 +              builtin_class = false;
    3.47 +              error ("internal error: undefined or invalid value in 
argument list");
    3.48 +            }
    3.49 +
    3.50          }
    3.51      }

If this is an internal error, is there some reason to not use
panic_impossible?

Or, do you think we should consider removing panic_impossible in favor
of error so that internal errors don't cause Octave to abort?

In addition to calls to panic_impossible, we also have some direct
calls to assert and abort.

I guess I'd like to be consistent in the way we handle internal "this
can't happen" kinds of errors.

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]