Re: CMatric.cc: ComplexMatrix::solve call is ambigious

[Jaroslav Hajek]

On Wed, Feb 24, 2010 at 11:47 AM, David Grundberg <address@hidden> wrote:
> Hi,
>
> Tried building today and I got this C++ method overloading compile error.
> This error is something new, so I thought I'd post it.
>

I know about this. The actual bug has been there for long, only now it
became a compile-time error thanks to the class hierarchy
simplification. I'll correct this in 1-2 hours as part of another
change (wiping out Array2). If you want to proceed now, I've extracted
the relevant pieces for you:

diff --git a/liboctave/CMatrix.cc b/liboctave/CMatrix.cc
--- a/liboctave/CMatrix.cc
+++ b/liboctave/CMatrix.cc
@@ -2394,7 +2394,8 @@
 {

   ComplexMatrix tmp (b);
-  return solve (typ, tmp, info, rcon, sing_handler,
transt).column(static_cast<octave_idx_type> (0));
+  tmp = solve (typ, tmp, info, rcon, sing_handler, true, transt);
+  return tmp.column(static_cast<octave_idx_type> (0));
 }

 ComplexMatrix
diff --git a/liboctave/dMatrix.cc b/liboctave/dMatrix.cc
--- a/liboctave/dMatrix.cc
+++ b/liboctave/dMatrix.cc
@@ -2050,7 +2050,8 @@
                double& rcon, solve_singularity_handler sing_handler,
blas_trans_type transt) const
 {
   Matrix tmp (b);
-  return solve (typ, tmp, info, rcon, sing_handler,
transt).column(static_cast<octave_idx_type> (0));
+  tmp = solve (typ, tmp, info, rcon, sing_handler, true, transt);
+  return tmp.column(static_cast<octave_idx_type> (0));
 }

 ComplexColumnVector
diff --git a/liboctave/fCMatrix.cc b/liboctave/fCMatrix.cc
--- a/liboctave/fCMatrix.cc
+++ b/liboctave/fCMatrix.cc
@@ -2387,7 +2387,8 @@
 {

   FloatComplexMatrix tmp (b);
-  return solve (typ, tmp, info, rcon, sing_handler,
transt).column(static_cast<octave_idx_type> (0));
+  tmp = solve (typ, tmp, info, rcon, sing_handler, true, transt);
+  return tmp.column(static_cast<octave_idx_type> (0));
 }

 FloatComplexMatrix
diff --git a/liboctave/fMatrix.cc b/liboctave/fMatrix.cc
--- a/liboctave/fMatrix.cc
+++ b/liboctave/fMatrix.cc
@@ -2049,7 +2049,8 @@
                float& rcon, solve_singularity_handler sing_handler,
blas_trans_type transt) const
 {
   FloatMatrix tmp (b);
-  return solve (typ, tmp, info, rcon, sing_handler,
transt).column(static_cast<octave_idx_type> (0));
+  tmp = solve (typ, tmp, info, rcon, sing_handler, true, transt);
+  return tmp.column(static_cast<octave_idx_type> (0));
 }

 FloatComplexColumnVector



regards

-- 
RNDr. Jaroslav Hajek, PhD
computing expert & GNU Octave developer
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz