missing "#include "sysdir.h" ?? [was Re: rpl_close in load-save.cc (MinGW build development source)

[Tatsuro MATSUOKA]

Hello

Under the build directory libgnu', there found unistd.h.
In the unistd.h

#if 1
# if 1
/* Automatically included by modules that need a replacement for close.  */
#  undef close
#  define close rpl_close
extern int close (int);
# endif
#elif 0
# undef close
# define close close_used_without_requesting_gnulib_module_close
#elif defined GNULIB_POSIXCHECK
# undef close
/* Assume close is always declared.  */
_GL_WARN_ON_USE (close, "close does not portably work on sockets - "
                 "use gnulib module close for portability");
#endif

#**************
>From the grep results by the term of 'unistd.h' I found

liboctave\sysdir.h(31): #include <unistd.h>

Addition of #include "sysdir.h" to load-save.cc
like 
 :
#include "version.h"
#include "dMatrix.h"
#include "sysdir.h" <====

Errors reduced to 
../../../hg/octave-work/src/load-save.cc: In function 'octave_value_list 
Fload(const
octave_value_list&, int)':
../../../hg/octave-work/src/load-save.cc:791: error: 'class hdf5_ifstream' has 
no member named 'close'
../../../hg/octave-work/src/load-save.cc: In function 'void dump_octave_core()':
../../../hg/octave-work/src/load-save.cc:1402: error: 'class hdf5_ofstream' has 
no member named
'close'
../../../hg/octave-work/src/load-save.cc: In function 'octave_value_list 
Fsave(const
octave_value_list&, int)':
../../../hg/octave-work/src/load-save.cc:1695: error: 'class hdf5_ofstream' has 
no member named
'close'
make[3]: *** [liboctinterp_la-load-save.lo] Error 1 

The error is now concerned to only to hdf5 related files.

Therefore I add to 

#include "oct-hdf5.h"
#include "sysdir.h"  <==add

// Remove gnulib definitions, if any.<==add
#ifdef close <==add
#undef close <==add
#endif       <==add 
#ifdef open  <==add
#undef open  <==add
#endif       <==add

The compile errors are disappeared.

I cannot judge the modifications the above are correct.
However, please consider the above for the MinGW building.

Regards

Tatsuro 



--- Tatsuro MATSUOKA  wrote:

> Hello
> 
> Sorry for my duplicated post,
> I have been struggling with  the error comes from  the symbol rpl_close.
> 
> To my poor ability I cannot overcome this issue.
> 
> Any suggestions?
> 
> Regards
> 
> Tatsuro
>  
> 
> --- Tatsuro MATSUOKA  wrote:
> 
> > Hello
> > 
> > Sorry for my ignorance the matter.
> > 
> > I have updated the development source 
> > *********
> > 2010-02-22  John W. Eaton  <address@hidden>
> > 
> >     * boostrap: Update from gnulib/build-aux/bootstrap.
> > *************
> > 
> > 
> > 
> > libtool: compile:  g++ -shared-libgcc -DHAVE_CONFIG_H -I. 
> > -I../../../hg/octave-work/src -I..
> > -I/WinDevTools/include -I/GnuWin32/include -I../libgnu 
> > -I../../../hg/octave-work/libgnu
> > -I../../../hg/octave-work/libcruft/misc -I../liboctave 
> > -I../../../hg/octave-work/liboctave -I.
> > -I../../../hg/octave-work/src -I/WinDevTools/include -I/GnuWin32/include 
> > -D_GLIBCXX_DLL -O3
> > -fomit-frame-pointer -DHAVE_CONFIG_H -mieee-fp 
> > -IC:/Programs/GnuWin32/include
> > -I/WinDevTools/bin/../include/freetype2 -I/WinDevTools/bin/../include
> > -Ic:/Programs/WinDevTools/include -Wall -W -Wshadow -Wold-style-cast 
> > -Wformat -D_GLIBCXX_DLL
> -O3
> > -fomit-frame-pointer -D_GLIBCXX_DLL -O3 -fomit-frame-pointer -MT 
> > liboctinterp_la-load-save.lo
> > -MD -MP
> > -MF .deps/liboctinterp_la-load-save.Tpo -c 
> > ../../../hg/octave-work/src/load-save.cc 
> > -DDLL_EXPORT
> > -DPIC -o .libs/liboctinterp_la-load-save.o
> > ../../../hg/octave-work/src/load-save.cc: In function 'bool 
> > check_gzip_magic(const
> > std::string&)':
> > ../../../hg/octave-work/src/load-save.cc:223: error: 'struct std::ifstream' 
> > has no member
> named
> > 'rpl_close'
> > ../../../hg/octave-work/src/load-save.cc: In function 'load_save_format 
> > get_file_format(const
> > std::string&, const std::string&, bool&)':
> > ../../../hg/octave-work/src/load-save.cc:297: error: 'struct std::ifstream' 
> > has no member
> named
> > 'rpl_close'
> > ../../../hg/octave-work/src/load-save.cc: In function 'octave_value_list 
> > Fload(const
> > octave_value_list&, int)':
> > ../../../hg/octave-work/src/load-save.cc:790: error: 'class hdf5_ifstream' 
> > has no member named
> > 'rpl_close'
> > ../../../hg/octave-work/src/load-save.cc:852: error: 'struct std::ifstream' 
> > has no member
> named
> > 'rpl_close'
> > ../../../hg/octave-work/src/load-save.cc:861: error: 'struct std::ifstream' 
> > has no member
> named
> > 'rpl_close'
> > ../../../hg/octave-work/src/load-save.cc:870: error: 'struct std::ifstream' 
> > has no member
> named
> > 'rpl_close'
> > ../../../hg/octave-work/src/load-save.cc: In function 'void 
> > dump_octave_core()':
> > ../../../hg/octave-work/src/load-save.cc:1401: error: 'class hdf5_ofstream' 
> > has no member
> named
> > 'rpl_close'
> > ../../../hg/octave-work/src/load-save.cc:1434: error: 'struct 
> > std::ofstream' has no member
> named
> > 'rpl_close'
> > ../../../hg/octave-work/src/load-save.cc: In function 'octave_value_list 
> > Fsave(const
> > octave_value_list&, int)':
> > ../../../hg/octave-work/src/load-save.cc:1694: error: 'class hdf5_ofstream' 
> > has no member
> named
> > 'rpl_close'
> > ../../../hg/octave-work/src/load-save.cc:1739: error: 'struct 
> > std::ofstream' has no member
> named
> > 'rpl_close'
> > ******
> > ../../../hg/octave-work/src/load-save.cc:223: error: 'struct std::ifstream' 
> > has no member
> named
> > 'rpl_close'
> > In load-save.cc
> > // Remove gnulib definitions, if any.
> > #ifdef close
> > #undef close
> > #endif
> > 
> > I commented out the above the error is the same.
> > 
> > This is different behavior the last results of the below
> >
>
http://old.nabble.com/Compile-error-of-load-save.cc-in-liboctinterp-(MinGW-build-for-3.3.50%2B)-tc27541770.html
> > 
> > Any suggestions?
> > 
> > Regards
> > 
> > Tatsuro
> > 
> > 
> > 
> > --------------------------------------
> > VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
> > http://pr.mail.yahoo.co.jp/olympic/
> > 
> 
> 
> --------------------------------------
> Get the new Internet Explorer 8 optimized for Yahoo! JAPAN
> http://pr.mail.yahoo.co.jp/ie8/
> 


--------------------------------------
Get the new Internet Explorer 8 optimized for Yahoo! JAPAN
http://pr.mail.yahoo.co.jp/ie8/