Re: Proposal for Matlab style errorbars (help requested)

[Shai Ayal]

On Sat, May 1, 2010 at 6:01 PM, Ben Abbott <address@hidden> wrote:
>
> On Apr 30, 2010, at 8:33 PM, David Bateman wrote:
>
>> Ben Abbott wrote:
>>> I've pushed the changes to __go_draw_axes__.m, but when I moved on to 
>>> graphics.h.in I noticed other files were referencing the {l,u,xl,xu}data 
>>> properties.
>>>
>>> Specifically, I see references to {l,u,xl,xu}data in graphics.cc, 
>>> graphics.h, graphics-props.cc, and graphics.h.in.
>>>
>>> Before I begin a (possibly) futile attempt to remove these references, I 
>>> thought I'd ask for advice as I'm functionally illiterate in c/c++.
>>>
>>> Ben
>>>
>>> p.s. I don't mind making a feeble attempt at changing these files, but 
>>> having someone more expert in c/c++ do it might be wise.
>>>
>>>
>>>
>> graphics.h and graphics-props.cc are created from graphics.h.in so don't 
>> change them. Only graphics.h.in and graphics.cc should be changed..
>>
>> The compute_xlim and compute_ylim methods in graphics.cc shoud be eliminated 
>> and {l,u,xl,xu}data eliminated elsewhere. The same for graphics.h.in, but 
>> the updata_xdata and updata_ydata methods should be made to resemble the 
>> updata_zdata method..
>>
>> These changes  are relatively simple
>> Cheers
>> David
>
> Thanks David.
>
> I've pushed the changeset below.
>
>        http://hg.savannah.gnu.org/hgweb/octave/rev/24e915c602e7
>
> Ben

During build I get the following error for each image octave tries to produce:
make[3]: *** [spchol.png] Error 1
../../run-octave -f -q -H -p . --eval "sparseimages ('spcholperm', 'png');"
error: structure has no member `ldata'
error: called from:
error:   /home/shaia/hack/octave-working/scripts/plot/__go_draw_axes__.m
at line 449, column 18
error:   /home/shaia/hack/octave-working/scripts/plot/__go_draw_figure__.m
at line 99, column 19
error:   /home/shaia/hack/octave-working/scripts/plot/gnuplot_drawnow.m
at line 56, column 9
error:   /home/shaia/hack/octave-working/scripts/plot/print.m at line
696, column 9
error:   /home/shaia/hack/octave-working/doc/interpreter/sparseimages.m
at line 130, column 2
error:   /home/shaia/hack/octave-working/doc/interpreter/sparseimages.m
at line 36, column 2

Other than that, works great, even in fltk!

Shai