[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: AspectRatio Patches [changeset]
From: |
Ben Abbott |
Subject: |
Re: AspectRatio Patches [changeset] |
Date: |
Thu, 28 Oct 2010 15:47:06 +0800 |
On Oct 28, 2010, at 3:31 PM, John W. Eaton wrote:
> On 28-Oct-2010, logari81 wrote:
>
> | thank you for reviewing the patches. The changelog entry seems to be ok.
>
> The entry is just
>
> | +2010-10-28 Konstantinos Poulios <address@hidden>
> | + * Fix the dataspectratio and plotboxaspectratio for the fltk
> | + backend.
> | +
>
> but it should really say which functions changed, and what changed.
> Something like:
>
> 2010-10-28 Konstantinos Poulios <address@hidden>
>
> * graphics.cc (updating_aspectratios): New file-scope variable.
> (axes::properties::update_aspectratios, axes::update_axis_limits):
> Return immediately if updating_aspecratios is true.
> (axes::properties::update_aspectratios):
> Some explanation of the other changes to this function
> (PLEASE ADD; I don't know what they are about).
> * graphics.h.in (class axes::properties): Tag dataaspectratio,
> dataaspectratiomode, plotboxaspectratio, and
> plotboxaspectratiomode with "u" qualifier.
> (axes::update_dataaspectratio,
> axes::update_dataaspectratiomode,
> axes::update_plotboxaspectratio,
> axes::update_plotboxaspectratiomode): New functions.
Thats my mistake. I can fix it.
Kostas, I'm not a c/c++ programmer, so I'll leave the rest to you. I'll wait
for the corrections before pushing a changeset.
Ben
- AspectRatio Patches, logari81, 2010/10/27
- Re: AspectRatio Patches, Ben Abbott, 2010/10/27
- Re: AspectRatio Patches, logari81, 2010/10/27
- Re: AspectRatio Patches, Ben Abbott, 2010/10/27
- Re: AspectRatio Patches, Ben Abbott, 2010/10/28
- Re: AspectRatio Patches [changeset], Ben Abbott, 2010/10/28
- Re: AspectRatio Patches [changeset], logari81, 2010/10/28
- Re: AspectRatio Patches [changeset], John W. Eaton, 2010/10/28
- Re: AspectRatio Patches [changeset],
Ben Abbott <=
- Re: AspectRatio Patches [changeset], logari81, 2010/10/28
- Re: AspectRatio Patches [changeset], logari81, 2010/10/28
- Re: AspectRatio Patches [changeset], Ben Abbott, 2010/10/29
- Re: AspectRatio Patches [changeset], John W. Eaton, 2010/10/29
- Re: AspectRatio Patches [changeset], Ben Abbott, 2010/10/29
- Re: AspectRatio Patches [changeset], logari81, 2010/10/31
- Re: AspectRatio Patches [changeset], Ben Abbott, 2010/10/31
- Re: AspectRatio Patches [changeset], logari81, 2010/10/31
- Re: AspectRatio Patches [changeset], Ben Abbott, 2010/10/31