Re: AspectRatio Patches [changeset]

[logari81]

On Fri, 2010-10-29 at 14:58 +0800, Ben Abbott wrote:
> On Oct 29, 2010, at 2:30 PM, John W. Eaton wrote:
> 
> > On 29-Oct-2010, Ben Abbott wrote:
> > 
> > | John, is it ok to push?
> > 
> > Yes, it seems OK to me.
> > 
> > Thanks,
> > 
> > jwe
> 
> Done.
> 
>       http://hg.savannah.gnu.org/hgweb/octave/rev/51ac3a08e53c
> 
> Ben

thank you for applying the changes.

I have investigated the problem with the wrong axes limits on page 5 of
my test case pdf and found out that the case with both
plotboxaspectratiomode and dataaspectratiomode set to manual was
explicitly handled (probably incorrectly) for the gnuplot backend in
plot/__go_draw_axes__.m
This code should be removed since the same calculation now is already
done (correctly) in src/graphics.cc .

So please consider the attached changeset.

As a side effect of this change, there is an important improvement of
the wrong plotbox size with the gnuplot backend in my test cases. See
the new comparison results of my tests here:

http://files.ubuntu-gr.org/forum/logari81/Bugs/comparison_aspectratios_update1.pdf

Best regards,

Kostas

aspectratios1.changeset
Description: Text document