Re: uimenu implementation, 2nd version [build failure on MacOS X]

[Ben Abbott]

On Oct 31, 2010, at 8:34 AM, Kai Habel wrote:

> On 29.10.2010 04:47, Ben Abbott wrote:
>> On Oct 27, 2010, at 1:47 AM, Kai Habel wrote:
>> 
>>> On 26.10.2010 06:32, Ben Abbott wrote:
>>>> On Oct 26, 2010, at 11:15 AM, Ben Abbott wrote:
>>>> 
>>>>> On Oct 26, 2010, at 1:03 AM, Kai Habel wrote:
>>>>> 
>>>>>> Ok, I have pushed an updated Changeset, with the uimenu implementation 
>>>>>> for the fltk backend.
>>>>>> 
>>>>>> Kai
>>>>> With this change, my buiid is failing
>>>>> 
>>>> /* snip */
>>>> 
>>>>> DLD-FUNCTIONS/fltk_backend.cc: In member function 'Matrix 
>>>>> fltk_uimenu::find_uimenu_children(T&) const':
>>>>> DLD-FUNCTIONS/fltk_backend.cc:339: error: request for member 
>>>>> 'get_position' in 
>>>>> 'dynamic_cast<uimenu::properties&>(kidgo.graphics_object::get_properties())',
>>>>>  which is of non-class type 'uimenu::properties&'
>>>>> DLD-FUNCTIONS/fltk_backend.cc:341: error: request for member 
>>>>> 'get_fltk_label' in 
>>>>> 'dynamic_cast<uimenu::properties&>(kidgo.graphics_object::get_properties())',
>>>>>  which is of non-class type 'uimenu::properties&'
>>>>> DLD-FUNCTIONS/fltk_backend.cc: In member function 'Matrix 
>>>>> fltk_uimenu::find_uimenu_children(T&) const [with T = 
>>>>> uimenu::properties]':
>>>>> DLD-FUNCTIONS/fltk_backend.cc:360:   instantiated from here
>>>>> DLD-FUNCTIONS/fltk_backend.cc:340: warning: unused variable 'lbl'
>>>>> DLD-FUNCTIONS/fltk_backend.cc: In member function 'Matrix 
>>>>> fltk_uimenu::find_uimenu_children(T&) const [with T = 
>>>>> figure::properties]':
>>>>> DLD-FUNCTIONS/fltk_backend.cc:554:   instantiated from here
>>>>> DLD-FUNCTIONS/fltk_backend.cc:340: warning: unused variable 'lbl'
>>>>> make[3]: *** 
>>>>> [DLD-FUNCTIONS/DLD_FUNCTIONS_fltk_backend_la-fltk_backend.lo] Error 1
>>>>> make[2]: *** [check] Error 2
>>>>> make[1]: *** [check-recursive] Error 1
>>>>> make: *** [check] Error 2
>>>>> 
>>>>> Ben
>>>> The lines of fltk_backend.cc which produce the error are
>>>> 
>>>>  335             if (kidgo.isa ("uimenu"))
>>>>  336               {
>>>>  337                 uimenu_childs(k) = uimenu_childs(ii);
>>>>  338                 pos(k++) =
>>>>  339                   dynamic_cast<uimenu::properties&>   
>>>> (kidgo.get_properties ()).get_position ();
>>>>  340                 std::string lbl =
>>>>  341                   dynamic_cast<uimenu::properties&>   
>>>> (kidgo.get_properties ()).get_fltk_label ();
>>>>  342               }
>>>> 
>>>> Perhaps this is related to this is a bug in the version of gcc I'm running?
>>>> 
>>>>    http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34364
>>>> 
>>>> $ gcc --version
>>>> i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>>>> Copyright (C) 2007 Free Software Foundation, Inc.
>>>> This is free software; see the source for copying conditions.  There is NO
>>>> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>>>> 
>>>> To allow the build to continue, I commented out this if-block, and didn't 
>>>> encounter any more errors (and as expected the uimenu doesn't function).
>>>> 
>>>> Ben
>>>> 
>>> Ben,
>>> 
>>> does the attached patch work for you?
>>> 
>>> Kai
>>> <patch.macos>
>> Kai,
>> 
>> Can this patch be pushed?
>> 
>> Ben
>> 
> Done.

Thanks
Ben