[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: compilation warnings in liboctave/CMatrix.cc
From: |
John W. Eaton |
Subject: |
Re: compilation warnings in liboctave/CMatrix.cc |
Date: |
Thu, 13 Jan 2011 15:41:12 -0500 |
On 13-Jan-2011, CdeMills wrote:
|
|
| Jordi GutiƩrrez Hermoso wrote:
| >
| > On 13 January 2011 04:40, CdeMills <address@hidden> wrote:
| >> Is it really worth a function ? Couldn't it be reduced to an inline func
| >> or
| >> some #define ?
| >
| > Please try to keep #defines at an absolute mininum. We've already run
| > into problems with rampant #defines causing obscure compiler errors in
| > X headers. By itself, inlining a function should not be a reason to
| > use #define; gcc is already very good at deciding which functions
| > should be inlined, even if you don't use the inline keyword.
| >
| > - Jordi G. H.
| >
| >
|
| Here you are
I checked in the following change.
http://hg.savannah.gnu.org/hgweb/octave/rev/53edbf95fbb6
Thanks,
jwe
- compilation warnings in liboctave/CMatrix.cc, (continued)
Re: compilation warnings in liboctave/CMatrix.cc, Jordi GutiƩrrez Hermoso, 2011/01/13