octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Array constructor backward compatibility problem


From: Jaroslav Hajek
Subject: Re: Array constructor backward compatibility problem
Date: Thu, 20 Jan 2011 08:51:37 +0100

On Thu, Jan 20, 2011 at 6:18 AM, John W. Eaton <address@hidden> wrote:
> On 19-Jan-2011, John W. Eaton wrote:
>
> | On 19-Jan-2011, John W. Eaton wrote:
> |
> | I also noticed that we have
> |
> |   void resize1 (octave_idx_type n, const T& rfv = resize_fill_value ());
> |
> |   void resize (octave_idx_type n) GCC_ATTR_DEPRECATED
> |
> |   void resize (octave_idx_type nr, octave_idx_type nc,
> |                const T& rfv = resize_fill_value ());
> |
> |   void resize (const dim_vector& dv, const T& rfv = resize_fill_value ());
> |
> | For consistency, maybe we should deprecate
> |
> |   void resize (octave_idx_type nr, octave_idx_type nc,
> |                const T& rfv = resize_fill_value ());
> |
> | as it can be replaced with
> |
> |   resize (dim_vector (nr, nc), rfv)
> |
> | Comments?
>
> I checked in a changeset:
>
>  http://hg.savannah.gnu.org/hgweb/octave/rev/a83bad07f7e3
>
> jwe
>

I'm OK with this. It's sad that we can't keep the interface
consistent, but it's probably better this way.
I thought I had also some optimization-related reason why I wanted
these, but now I can't see it. Maybe it was something that went away
anyway.

thanks for cleaning this up :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]