octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

src/ov-base.h, class octave_base_value


From: John W. Eaton
Subject: src/ov-base.h, class octave_base_value
Date: Mon, 31 Jan 2011 16:54:25 -0500

On 31-Jan-2011, CdeMills wrote:

| I was trying to understand the purpose of the static data at the end of the
| class definition:
|  static int curr_print_indent_level;
|   static bool beginning_of_line;
| 
| The last value is mainly used inside functions
| octave_base_value::indent (std::ostream& os) 
| octave_base_value::newline (std::ostream& os) 
| As those functions are always used in the context of a std::ostream,
| shouldn't we derive one class of std::ostream and move the value
| beginning_of_line, and functions indent and newline, there ?

Yes, perhaps.  Propose a patch that will allow these to be moved from
the octave_value class.  A change like this will not go in 3.4 though.

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]