octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warnings originating in gl2ps -- update


From: John W. Eaton
Subject: Re: warnings originating in gl2ps -- update
Date: Thu, 10 Feb 2011 13:36:05 -0500

On 10-Feb-2011, CdeMills wrote:

| The corresponding patch is
| --- a/src/load-path.cc        Thu Feb 10 00:58:31 2011 -0500
| +++ b/src/load-path.cc        Thu Feb 10 19:15:58 2011 +0100
| @@ -617,7 +617,7 @@
|    while (k > 1 && file_ops::is_dir_sep (dir[k-1]))
|      k--;
|  
| -  if (k < dir.length ())
| +  if ((dir.length () - k) > 0)
|      dir.resize (k);
|  
|    return dir;
| 
| This removes the warning. 

OK, if you can remove the warnings without a cast, then submit a
patch.  But could you please write

  if (dir.length () - k > 0)

instead?

Thanks,

jwe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]