Re: PCRE regexp bugs

[Rik]

>>> >> 2/19/11
>>> >>
>>> >> John,
>>> >>
>>> >> Could you take a look at requiring building with PCRE in
>>> configure.ac? The
>>> >> build experiences on Mac OS have demonstrated that POSIX regex are not
>>> >> sufficient; moreover, most Octave coders were already implicitly
>>> writing
>>> >> Perl-style regex. I just checked in a changeset which updates the
>>> >> documentation and all of the regexp instances in the codebase to
>>> use PCRE
>>> >> style expressions
>>> (http://hg.savannah.gnu.org/hgweb/octave/rev/e4dbfe3019b1)
>>> >>
>>> >> Cheers,
>>> >> Rik
>>> >
>>> > I found a bug in "get_forge_package" that was introduced
>>> > by this changeset, a fix is in the bug tracker here:
>>> >
>>> > <http://savannah.gnu.org/bugs/?32559>
>>> >
>>> > I've not checked if other PCRE style regular expressions also have the
>>> > same problem.
This was an unusual regexp.  Where possible, all of the regexp have been
converted to use single quotes to prevent variable interpolation problems
such as the one you found.  I have committed your patch.
>>> > c.
>>>
>>> Believe me, there are more. There's one in __gnuplot_has_terminal.m
>>> iirc, and who knows how many others.
There are many other uses of regexp, but there shouldn't be many more
errors.  I did go through all of them one by one and 'make check' passes
without errors.
>>>
>>> Campbell
>>  
>> Richard, I recall you (someone?) mentioning this before and proposing
>> a change. Unfortunately, I'd forgotten about it.
>>
>> May I ask that you submit a changeset to the patch tracker?
>>
>> http://savannah.gnu.org/patch/?group=octave
>>
>> I've begun looking at the patches there and hope to take care of most
>> of them this week (unless someone beats me to it).
>>
>> Ben
>>
> 
> Ben,
> 
> It wasn't me, it was Rik. Here's the
> thread: 
> https://mailman.cae.wisc.edu/pipermail/octave-maintainers/2011-January/022648.html
> 
> I submitted a "require PCRE" patch some time ago and I don't see it on
> the list of patches now - I think someone else might have pushed a
> better one already.
> 
> Campbell
> 

JWE committed this patch
(http://hg.savannah.gnu.org/hgweb/octave/rev/dfeea9cae79e) which adds the
requirement for PCRE to the build process.


--Rik