Re: Small fix of column number in parser

[Daniel Kraft]

On 04/28/11 16:13, Jordi Gutiérrez Hermoso wrote:
> 2011/4/28 Daniel Kraft<address@hidden>:
>
> > Regarding testing a patch before commit (or submitting it), is there
> > some "standard required way" -- i.e., running "make check" without
> > errors or something else?
>
> Yes, "make check" should be part of your testing, make sure you didn't
> break something inadvertently.

Ok, I'll remember this for all future patches ;)

> > > > Do you prefer this simple patch or should I work on some
> > > > "clean-up" of this situation, too -- like making skip_white_space
> > > > a member of stdio_stream_reader and unifying column- and
> > > > line-number tracking in one place.
> > >
> > > I think for a first patch, a minimal solution is fine. Leave the
> > > refactoring for later.
> >
> > Ok. So should I now work on a refactoring?
>
> No, I don't think this problem is worth it. Do you disagree? Find
> bigger fish to fry.

I totally agree here.

And thanks for the hg tips!

Yours,
Daniel

--
http://www.pro-vegan.info/
--
Done:  Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Mon-Pri