Re: [Patch] FIrst experimental profiler

[Daniel Kraft]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jordi,

On 07/14/11 08:31, Jordi Gutiérrez Hermoso wrote:
> 2011/6/30 Daniel Kraft <address@hidden>:
>> Attached is my current working code for the first experimental
>> profiler.
> 
> I have pushed your code on the default branch, along with the
> following minor stylistic fixes:

thanks!  To summarize, the stylistic changes you made were:

  * Return variables are called ratval.

  * Only warn about ignoring extra arguments.

  * Call print_usage() otherwise for missing arguments and the like.

Right?  Ok, then I'll try to follow those conventions in the future.

> I briefly tested your code, and it seems to work. Looks like a solid
> initial implementation. Can you quickly mimic the Matlab interface to
> profiling? I think this should be quick and should not take longer
> than a week. The next step I'd like to see after that is to produce
> hierarchical profiling output and to also count operators in the
> profiling output.

Yes, I also think that it should be possible to do the Matlab interface
soon.  It contains some more fields than is currently available
(especially the list of parent/child functions), but I can either ignore
those for now or implement missing bits which seem easy (those lists
don't look like a "real" hierarchical output and I think should be
straight-forward to implement).

And I agree that after that, we should think about real hierarchical
output.  I like the idea by Andy Wingo and Paolo Bonzini that we might
output data in gprof or callgrind format so that we can reuse that tools
- -- at least as an option; so maybe I'll look at this more closely.  BTW,
does Matlab support hierarchical output with a "standard" interface?  I
don't remember I read about this when looking up "profile".

With count operators you mean profiling per line or "just" to count the
number of statements executed alongside the time?

Yours,
Daniel

- -- 
OpenPGP: 3BA2 3DDB 7758 F010 BDAB 0DCF 527E 79BA A3B5 3998
- --
Done:  Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Mon-Pri
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOHpyKAAoJEFJ+ebqjtTmYghoQAMLuSt39xQH1Z+jpn168IKnK
NXk2lGPTZVOtXTzMKK8T26/bvorOhE61Nohh+Vji4ELL4/ydQuLtqaJhUDm+rla6
QnSBVvxEC70me+n5mC1xhnkwj1yFrODLsuwvJJkNN3N4k6c9/bO5sktc4N3VpAsK
pXVhNPijQ5hh+YRkqNBC5fDypa3F+WKbzuP6CsTpzOoZVQcFitykoVXCgbSJNjdI
llfTdmOY2RDbBQGBrCi4TZ3Pp9jhzRixyK0piF3S0yCyLcAO71fk2eLYghnKv8GL
wYpwDTJr56Qd+tHKGeEpO0MBJ5N3XCTRhRvNUHXX8u8R2fJmLOdkb25gJndhcURh
fRUswauFcp6vHuBBGRQuuxf+hpek8vuOj3DMiO23l236HRwwBk/4cEZVPyB3W/mD
9DEVr8O+LXwt5zUNQ7zy0q9zpBOp+zW6z1nNWoZFB4LTxJF4y4nxu0MXMO1LyZ/q
Bc2rlA5DHRvQOQHvWF0vsF5XDuqmZ8mXFVSmof4qb5EMliD8dDpFxXImBJxcS9cH
p0bBISwlVHrcn+1Q1QueHTR9bsO1MJHTMiNm7nHmCMxmZ1z+g3fQ+kiC0ZRYm2EJ
uamEfvyryzvfLF+Tz2W/aclP8CRo/xmoH4Mn5mYFFgqTKFRrPfowf/n+JwukF/VI
ufYTEYsdADrKCCN0/463
=Um1W
-----END PGP SIGNATURE-----