Re: Follow up on profiler development

[Daniel Kraft]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/10/11 17:22, John W. Eaton wrote:
> On  9-Aug-2011, Daniel Kraft wrote:
> 
> | > Can you in fact provide some gprof output (run a few demos or
> tests) | > and make sure that the profiling code functions are all
> very low in | > the profiling output? Let me know if you manage. I
> had some trouble | > writing profiling instrumentation data into the
> Octave binary with | > gprof, so I used oprof instead. If you also
> have trouble with gprof | > try with oprof, but I would like some
> reassurance that we are not | > slowing things down. | | I'll try to
> do this after data collection for hierarchical profiles is | done;
> then the backend should be complete (in a first stage at least), |
> even if we still play around with the UI to hierarchical data.  And |
> thanks for the hints with gprof -- I'll try it, but if I fail I'll
> try | with oprof.
> 
> If instead of
> 
> { profile_data_accumulator::enter pe (profiler, profiler_name ()); 
> cmd_list->accept (*current_evaluator); }
> 
> we wrote something like
> 
> { if (profile_data_accumulator::active ()) 
> profile_data_accumulator::enter pe (profiler, profiler_name ());
> 
> cmd_list->accept (*current_evaluator); }

That actually wouldn't have the same effect -- since "pe" would be local
in scope to the if-block.  (Or am I just stupid at the moment?)  I don't
see how we could "easily" do that so that it has the desired effect.

But if you have a suggestion (or of course if we see that timing is not
neglible in the current implementation), I'm happy to change the code
accordingly.

Yours,
Daniel


- -- 
OpenPGP: 3BA2 3DDB 7758 F010 BDAB 0DCF 527E 79BA A3B5 3998
or use https://safesend.domob.eu/
- --
Done:  Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Mon-Pri
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOQrX6AAoJEFJ+ebqjtTmYsbwP/0jyIxK2xA1dzCNMOKUJbQWV
C31suj3MB0KJCraa0ZGttZU+BzhnCdpAurfsuptVYSudCHKgm9wVDaPC1oz3mlNt
Y2JxIWD0ZgML4TrmhytG8VmEixE+RgblRtEt5baUbeg+ca3OkcTOMMcYDFkwKBEh
tQ/Lp3ehpJ/zrM+TX25pSfpdy2OlsnLJuR6HgXIQwrSTC7tjtKry0zaJBFk4bQEM
Sejg65+VWuxc5dT4uqGJD2km6A+MakknCKRN5nw866DPOpcf4KBMDjCzMS9YIYJe
Z/yMDS+JZ6ODt69CdeQyToqAD9xplXOVzRfpk4zI4RdV/lm36SY6OGbRBnkzCdYY
q6zl2IjCuDcXzF/hEQEZ08/6uZK20EGcS3u9Eo2u0FNzPL4z2Oy54Uphbcy/vpNu
hC767oa4QDzvfv61OSZa5rfaYiotms7lLAA770z2WpoQmdvFavxzFXZw8dauUKUj
QWd6iwdNBySSq7KadvoM49pWtjo5Oje0MlCUEalyLc9jIqOSBNBKnjsvZhKFwalp
zAhwegL6J07VwNaobsb3E8b2IBRiefM5YXYbqlZqKn+Ot4IerVoS3Tkg3T5RQdKZ
aYYbUZscer4L9ZBvbJ369iwHgi62SDCpzyl66NQE7Q2UMGD38Kh7GBE40rnDPrGQ
WpQh6NUTJNvAdUhMMt9R
=gzrG
-----END PGP SIGNATURE-----

smime.p7s
Description: S/MIME Cryptographic Signature