octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dMatrix.cc test failures


From: Ben Abbott
Subject: Re: dMatrix.cc test failures
Date: Tue, 23 Aug 2011 21:01:03 -0400


On Aug 23, 2011, at 8:47 PM, John W. Eaton wrote:

On 23-Aug-2011, Ben Abbott wrote:

| On Aug 23, 2011, at 6:11 PM, Marco atzeri wrote:
|
| > changeset f217edac2c71 "fix dimension check for A'\B (bug #33997)"
| > introduces the "Mt, rvt2 but forgot to declared as shared
| >
| > some other tests are failing (on cygwin) for tolerance
| >
| > proposed change:
| >
| > diff -r 7aa9cb7aaa32 liboctave/dMatrix.cc
| > --- a/liboctave/dMatrix.cc      Tue Aug 23 14:00:02 2011 -0500
| > +++ b/liboctave/dMatrix.cc      Wed Aug 24 00:02:58 2011 +0200
| > @@ -3111,7 +3111,7 @@
| > */
| >
| > /* Test some simple identities
| > -%!shared M, cv, rv
| > +%!shared M, cv, rv, Mt, rvt
| > %! M = randn(10,10)+100*eye(10,10);
| > %! Mt = M';
| > %! cv = randn(10,1);
| > @@ -3119,10 +3119,10 @@
| > %! rv = randn(1,10);
| > %! rvt = rv';
| > %!assert([M*cv,M*cv],M*[cv,cv],1e-14)
| > -%!assert([M'*cv,M'*cv],M'*[cv,cv],1e-14)
| > -%!assert([rv*M;rv*M],[rv;rv]*M,1e-14)
| > -%!assert([rv*M';rv*M'],[rv;rv]*M',1e-14)
| > -%!assert(2*rv*cv,[rv,rv]*[cv;cv],1e-14)
| > +%!assert([M'*cv,M'*cv],M'*[cv,cv],3e-14)
| > +%!assert([rv*M;rv*M],[rv;rv]*M,3e-14)
| > +%!assert([rv*M';rv*M'],[rv;rv]*M',3e-14)
| > +%!assert(2*rv*cv,[rv,rv]*[cv;cv],3e-14)
| > %!assert(M'\cv,Mt\cv,1e-14)
| > %!assert(M'\rv',Mt\rvt,1e-14)
| > */
|
| I was going to push the attached changeset reflecting your patch, but noticed that the variable "cvt" has also been defined, but is not used.
|
| Perhaps it is best to wait on John to comment.

I don't think cvt is needed, so you can remove that.  The tolerances
were just guesses based on the other existing tests and worked for
me.  Please go ahead and push a fix.

Thanks,

jwe

I pushed a changeset.

http://hg.savannah.gnu.org/hgweb/octave/rev/0413227e407b

Ben

reply via email to

[Prev in Thread] Current Thread [Next in Thread]