octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ambiguous call to "pow(int, unsigned int&)" in __magick_read__.cc:76


From: c.
Subject: Re: ambiguous call to "pow(int, unsigned int&)" in __magick_read__.cc:763
Date: Mon, 29 Aug 2011 09:19:22 +0200

On 28 Aug 2011, at 20:27, Jordi Gutiérrez Hermoso wrote:

> 2011/8/28 c. <address@hidden>:
> 
>> I see at other places in the file the same problem is handled by
>> 
>> // FIXME -- maybe simply using bit shifting would be better?
>> unsigned int div_factor = pow (2.0, static_cast<int> (bitdepth)) - 1;
>> 
>> do, is it OK if I push the attached patch?
>> c.
> 
> That seems like it should be done by bitshifting indeed. Why don't you
> push a bitshifting patch instead?
> 
> - Jordi G. H.

OK, so I pushed the changeset below.
As this is a fix rather than a new development I pushed it to "stable", hope 
this was right
c.

Attachment: bitshift.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]