Re: pcg.m replacement for OCTAVE

[Andrew Knyazev]

I've made the requested changes, see attached.

I could not find an editor with "smart indentation", so there might be
some spots missed.

Just for curiosity, what is the point of intentionally making Octave
core codes, such as pcg.m, such that they cannot be run in MATLAB and
cannot be edited by the MATLAB editor?

There are few other functions which I plan to submit both to core Octave
and MATLAB, so it would be nice if they were just the same.

On 09/06/2011 11:57 PM, Jordi Gutiérrez Hermoso wrote:
> On 6 September 2011 23:04, Andrew Knyazev <address@hidden> wrote:
>> > Attach please find a proposed update of OCTAVE's function pcg.m It
>> > is backward compatible and tested. The changes are described in the
>> > comments and demos of the code. Could you please replace the current
>> > pcg.m with the new revision attached in OCTAVE?
> Thank you for your suggested patches. The reference you added will
> come in handy, and more demos and tests are also welcome. I will let
> Piotr comment on the flexible CG idea itself, but at a first glance,
> it looks like a useful addition. For my part, I only want to comment
> on a few minor stylistic things:
> 
>     - We prefer to use ## comments to Matlab-style % comments.
> 
>     - Indentation and whitespace should be consistent.
> 
>     - Code duplication is undesirable. The last two tests have a lot
>       of this. It would be better to have them together as a single
>       test.
> 
>     - Octave is not an acronym, so there is no need to SHOUT IT. ;-)
> 
> These are all minor things that I or Piotr can edit in order to
> extract your thoughtful contributions.
>

pcg.m
Description: application/vnd.wolfram.mathematica.package