octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Potentially "dangerous" changeset, please test


From: Michael Goffioul
Subject: Re: Potentially "dangerous" changeset, please test
Date: Fri, 30 Sep 2011 08:08:09 +0100

2011/9/30 Jordi Gutiérrez Hermoso <address@hidden>:
> I pushed the following which is suposed to optimise several cases for
> randperm, which is important now that I've made randperm a central
> function for the sprand family of functions:
>
>    http://hg.savannah.gnu.org/hgweb/octave/rev/dd3c5325039c
>
> However, this change is potentially "dangerous" because it uses an
> "experimental" C++ feature (actually, it was experimental eight years
> ago). If you see build failures on rand.cc related to tr1 or
> unordered_map please blame me.

Just a suggestion: write a configure tests to check various things, like
- existence of unordered_map, fallback to std::map
- location of unordered_map header (<tr1/unordered_map> vs. <unordered_map>
- namespace required: std::tr1 vs. std

Michael.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]