octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: do_load differs in load-save.cc and load-save.h


From: John W. Eaton
Subject: Re: do_load differs in load-save.cc and load-save.h
Date: Tue, 4 Oct 2011 20:34:49 -0400

On  4-Oct-2011, Jordi Gutiérrez Hermoso wrote:

| 2011/10/4 c. <address@hidden>:
| >
| > On 5 Oct 2011, at 00:34, Jordi Gutiérrez Hermoso wrote:
| >
| >> Uhm... what?
| >>
| >>    
http://hg.savannah.gnu.org/hgweb/octave/file/4916b436d0bb/src/load-save.cc#l330
| >>
| >> How did you miss it? It's readily greppable. Or am *I* missing something?
| >>
| >> - Jordi G. H.
| >
| > Jordi,
| >
| > Sorry for not being clear enough,
| > the two functions look different to me.
| >
| > in load-save.h the order of the argument types is:
| > std::istream&, const std::string&, bool, etc...
| >
| > while in load-save.cc it is:
| > std::istream&, const std::string&, load_save_format, etc...
| >
| > an input parameter of type bool is missing in the definition or is unneeded 
in the declaration?
| > or is there anoother reason why the two differ?
| 
| You're right, it's an error. But do_load is only called internally in
| load-save.cc, so there's no reason why its declaration should be
| correct. Just push a patch to remove the erroneous declaration from
| load-save.h.

We could just make it static and delete the declaration, but I have no
objection to leaving it extern so other code can call it.

I fixed the declaration.

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]