Re: Using copysignf modules from gnulib

[Marco Atzeri]

On 10/20/2011 4:37 PM, Michael Goffioul wrote:
> On Thu, Oct 20, 2011 at 3:09 PM, John W. Eaton<address@hidden>  wrote:
> > On 20-Oct-2011, Michael Goffioul wrote:
> >
> > | On Wed, Oct 19, 2011 at 1:19 PM, Michael Goffioul
> > |<address@hidden>  wrote:
> > |>  Hi,
> > |>
> > |>  Octave currently uses the copysign module from gnulib, but not the
> > |>  copysignf one. It's easy to add it, but then comes a problem in
> > |>  lo-mappers.h. Because of inline implementations of xcopysign and
> > |>  xcopysignf, the gnulib replacements should be visible from that
> > |>  header, meaning we'd have to expose gnulib internals in the API. I
> > |>  guess we don't want to do that. The other solution would be to move
> > |>  implementation of xcopysign and xcopysignf in the source file. Would
> > |>  that be an acceptable solution?
> > |
> > | Something like the attached patch. Would it be ok to push it?
> >
> > Sorry I didn't respond earlier.  This change seems fine to me.
>
> Ok, thanks. I've pushed it:
> http://hg.savannah.gnu.org/hgweb/octave/rev/30414ff19d5e
>
> Michael.

missed something ?

$ ./autogen.sh
...
gnulib-tool: warning: module copysignf doesn't exist

Marco