Re: Octave-gui build fails for MinGW on current gui branch source

[Tatsuro MATSUOKA]

Hello

Grammatical error correction:

> When qterminal will be used in Windows, I attach the reverse patch.
> Hope your work will be successful.

==>
Unitil qterminal will be used in Windows, I attach the reverse patch.
--- On Thu, 2012/1/26, Tatsuro MATSUOKA  wrote:

> Hello Jacob
> 
> You have already said the answer.
> http://octave.1599824.n4.nabble.com/How-to-download-the-gui-on-the-Mecurial-repository-and-requirements-td4219607.
> 
> ****************************
> Since I don't have much time, I will keep my answer short. lqterminal is unix 
> only atm, so you just remove it when building for windows. The long-term goal 
> is to make qterminal a platform-indepedent terminal.
> **************************
> 
> When qterminal will be used in Windows, I attach the reverse patch.
> Hope your work will be successful.
> 
> Regards
> 
> Tatsuro
> 
> --- On Wed, 2012/1/25, Tatsuro MATSUOKA  wrote:
> 
> > Hello
> > 
> > I have attached the reverse patch of changeset 14255:5dcfb705ce12 and tried 
> > to build octave-gui. Of course, build went well.
> > However, this is a quick hack.
> > If the qterminal is not applied to the Windows, the source of octave-gui 
> > should be prepared considering the Windows.
> > 
> > Regards
> > 
> > Tatsuro
> > 
> > --- On Wed, 2012/1/25, Tatsuro MATSUOKA  wrote:
> > 
> > > Hello
> > > 
> > > In the source, the Qterminal related code exist.
> > > For example, in MainWindow.h 
> > > line 38
> > > #include "QTerminal.h"
> > > 
> > > line 65
> > >   QTerminal *terminalView ()
> > >   {
> > >     return m_terminalView;
> > >   }
> > > 
> > > Then source files should be changed for windows build, I think.
> > > 
> > > Regards
> > > 
> > > Tatsuro
> > > 
> > > --- On Wed, 2012/1/25, Jacob Dawid wrote:
> > > 
> > > > Try the latest source please. I have excluded qterminal as a dependency 
> > > > on Windows.
> > > > 
> > > > 
> > > > Am 25. Januar 2012 02:09 schrieb Jacob Dawid <address@hidden>:
> > > > I will commit a fix that should solve that problem for Windows in a 
> > > > while.
> > > > 
> > > > 
> > > > Am 25. Januar 2012 01:48 schrieb Tatsuro MATSUOKA <address@hidden>:
> > > > 
> > > > 
> > > > Hello
> > > > 
> > > > Due to very recent change octave-gui source, I could not build 
> > > > octave-gui on MinGW.
> > > > 
> > > > **********************
> > > > 
> > > > g++ -c -Ic:\Programs\OctaveBuild\include\octave-3.6.0\octave\.. 
> > > > -Ic:\Programs\OctaveBuild\include\octave-3.6.0\octave 
> > > > -Ic:\Programs\OctaveBuild\include -D_WIN32_WINNT=0x0502 -O2 -frtti 
> > > > -fexceptions -mthreads -Wall -DUNICODE -DQT_LARGEFILE_SUPPORT -DQT_DLL 
> > > > -DQT_NO_DEBUG -DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB 
> > > > -DQT_CORE_LIB -DQT_HAVE_MMX -DQT_HAVE_3DNOW -DQT_HAVE_SSE 
> > > > -DQT_HAVE_MMXEXT -DQT_HAVE_SSE2 -DQT_THREAD_SUPPORT -DQT_NEEDS_QMAIN 
> > > > -I'c:/Programs/Qt/4.8.0/include/QtCore' 
> > > > -I'c:/Programs/Qt/4.8.0/include/QtNetwork' 
> > > > -I'c:/Programs/Qt/4.8.0/include/QtGui' 
> > > > -I'c:/Programs/Qt/4.8.0/include/QtWebKit' 
> > > > -I'c:/Programs/Qt/4.8.0/include' -I'src' -I'src/terminal' -I'src/qirc' 
> > > > -I'src/backend' -I'qterminal/libqterminal' 
> > > > -I'-Ic:/Programs/OctaveBuild/include/octave-3.6.0/octave/..' 
> > > > -I'-Ic:/Programs/OctaveBuild/include/octave-3.6.0/octave' 
> > > > -I'-Ic:/Programs/OctaveBuild/include' -I'c:/Programs/gplibs/include' 
> > > > -I'c:/Programs/OctaveLibs/include'
> > > >  -I'c:/Programs/GnuWin32/include' -I'src/terminal/win32' 
> > > > -I'c:/Programs/Qt/4.8.0/include/ActiveQt' -I'moc-files' -I'ui-files' 
> > > > -I'c:/Programs/Qt/4.8.0/mkspecs/default' -o object-files/MainWindow.o 
> > > > src/MainWindow.cpp
> > > > In file included from src/backend/OctaveLink.h:28:0,
> > > >                  from src/MainWindow.h:31,
> > > >                  from src/MainWindow.cpp:25:
> > > > c:\Programs\OctaveBuild\include\octave-3.6.0\octave\../octave/config.h:2767:0:
> > > >  warning: "_WIN32_WINNT" redefined [enabled by default]
> > > > <command-line>:0:0: note: this is the location of the previous 
> > > > definition
> > > > In file included from src/MainWindow.cpp:25:0:
> > > > src/MainWindow.h:38:23: fatal error: QTerminal.h: No such file or 
> > > > directory
> > > > compilation terminated.
> > > > make[1]: *** [object-files/MainWindow.o] Error 1
> > > > make[1]: Leaving directory `/home/octaves/hg/octave-gui/gui'
> > > > make: *** [release] Error 2
> > > > *****************************
> > > > 
> > > > Unlike the Ubuntu, there is not 'qterminal' directory in gui directory 
> > > > for the Windows.
> > > > What should I do to avoid the error from qterminal related things on 
> > > > the Windows?
> > > > 
> > > > Regards
> > > > 
> > > > Tatsuro
> > > > 
> > > > 
> > > > 
> > > > -- 
> > > > „Alle sagten: Das geht nicht. Da kam einer, der wusste das nicht und 
> > > > hat's gemacht.“ - Unbekannt
> > > > 
> > > > 
> > > > 
> > > > -- 
> > > > „Alle sagten: Das geht nicht. Da kam einer, der wusste das nicht und 
> > > > hat's gemacht.“ - Unbekannt
> > > >
> > >
> >
>