Re: EDITOR issue [WAS: Octave-3.6.1 for Windows (VS2008/VS2010) available]

[Michael Goffioul]

On Sun, Mar 4, 2012 at 5:07 PM, Philip Nienhuis <address@hidden> wrote:
> Hi Michael:
>
> Michael Goffioul wrote:
>>
>> On Sat, Mar 3, 2012 at 6:36 PM, PhilipNienhuis<address@hidden>
>>  wrote:
>
> <snip>
>>>
>>> I suppose you're after some testing results. OK, I tried the MSVC 2010
>>> version (I selected "SSE3 multithreaded" on my Core Duo box).
>>
>>
>> Thanks for testing.
>
>
> Do you want issues to be reported in the bug tracker, this ML, sourceforge
> OctDev ML, or even privately?
> I see the MSVC binaries as experimental for the time being, so the bug
> tracker may not be the best option right now until the binaries are stable.

No the bug tracker should not be used for packaging issues.

> Anyway, another issue (MSVC2008 version):
> As you can see below, Octave doesn't pick up a new EDITOR VALUE.
> Although it does suggest so (see command 28), the FUNCTION struct still says
> "emacs":
>
> octave-3.6.1.exe:25> EDITOR ('C:\Programs\Notepad++\notepad++.exe')
> octave-3.6.1.exe:26> edit mfsetup.m
> error: system: CreateProcess failed -- can't create child process
> error: called from:
> error:
> C:\Programs\Octave\Octave-3.6.1_MSVC2008\share\octave\3.6.1\m\miscellaneous\edit.m
> at line 299, column 7
> octave-3.6.1.exe:26> dbstop edit 299
> ans =  299
> octave-3.6.1.exe:27> edit mfsetup.m
> stopped in
> C:\Programs\Octave\Octave-3.6.1_MSVC2008\share\octave\3.6.1\m\miscellaneous\edit.m
> at line 299
> 299:       system (sprintf (FUNCTION.EDITOR, cstrcat ("\"", fileandpath,
> "\"")),
> debug> FUNCTION
> FUNCTION =
>
>  scalar structure containing the fields:
>
>    EDITOR = emacs %s
>    HOME = C:\Home\philip\octave
>    AUTHOR = philip
>    EMAIL = <address@hidden>
>    LICENSE = GPL
>    MODE = async
>    EDITINPLACE = 0
>
> debug> dbquit
>
> octave-3.6.1.exe:28> EDITOR
> ans = C:\Programs\Notepad++\notepad++.exe
> octave-3.6.1.exe:29>

I think your problem is due to the persistent variables in edit.m.
Once that function has been called, the EDITOR content does not have
any effect anymore (because the persistent variable has been
initialized). See the 2 session examples below:

octave-3.6.1.exe:1> EDITOR ('notepad')
octave-3.6.1.exe:2> edit get editor
ans = notepad %s

octave-3.6.1.exe:1> edit get editor
ans = emacs %s
octave-3.6.1.exe:2> EDITOR ('notepad')
octave-3.6.1.exe:3> edit get editor
ans = emacs %s

This is not MSVC-specific, and I'm not even sure it's a bug (I guess
it's a matter of taste).

Michael.