octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: textread fix


From: Rik
Subject: Re: textread fix
Date: Sun, 04 Mar 2012 10:15:12 -0800

On 03/04/2012 08:16 AM, address@hidden wrote:
> Message: 3
> Date: Sun, 4 Mar 2012 15:29:57 +0100
> From: "c." <address@hidden>
> To: address@hidden
> Subject: small bug in textread
> Message-ID: <address@hidden>
> Content-Type: text/plain; charset="us-ascii"
>
> The following command triggers an error in textread:
>
> [a, b, c] = textread (f, "%f, %f, %f", "headerlines", 3);
>
> the applied patch fixes the error and adds a test for it,
> any objections if I push it?

The patch works for me.  I would change one line of the patch.

Instead of

if (numel (varargin) && isnumeric (varargin{1}))

I think it would be clearer to write

if (! isempty (varargin) && isnumeric (varargin{1}))

--Rik


reply via email to

[Prev in Thread] Current Thread [Next in Thread]