octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problem with printing plots


From: Michael Goffioul
Subject: Re: Problem with printing plots
Date: Sat, 10 Mar 2012 22:21:55 +0000

On Sat, Mar 10, 2012 at 10:18 PM, Ben Abbott <address@hidden> wrote:
> On Mar 10, 2012, at 11:15 AM, Michael Goffioul wrote:
>
>> On Sat, Mar 10, 2012 at 3:51 PM, Ben Abbott <address@hidden> wrote:
>>> Nice. I hadn't noticed the resize method before, and wouldn't have realized 
>>> it could be used to copy a 1x2 octave_value into a 1x3 octave_value.
>>>
>>> The attached works for me. Ok to push ?
>>
>> I would:
>> 1) move the set_position implementation into graphics.h.in
>> 2) use 'smu' for the position property declaration modifiers
>>
>> If you really want to keep the implementation in graphics.cc, then:
>> 1) use 'Smu' for the position property declaration modifiers
>> 2) remove the declaration of set_position in graphics.h.in (it'll be
>> auto-generated)
>>
>> Michael.
>
> I only added it to graphics.cc because I've added other methods there.
>
> The attached adds the method to graphics.h.in.
>
> If it looks ok, I'll push it.

Looks fine to me. If it doesn't produce any (obvious) regression, I
suggest you push it. Thanks for taking care of the issue.

Michael.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]