[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for edit help not matching behavior
From: |
Mike Miller |
Subject: |
Re: Patch for edit help not matching behavior |
Date: |
Wed, 21 Mar 2012 18:21:06 -0400 |
2012/3/21 Jordi Gutiérrez Hermoso <address@hidden>:
> On 21 March 2012 17:39, Mike Miller <address@hidden> wrote:
>> After switching from 3.2 to development recently, I started getting
>> hit with the edit async/sync default change. That's fine, I can
>> adapt, but the help was never updated. Attached patch describes the
>> sync/async mode correctly.
>
> Thanks, I rebased to the stable branch and pushed:
>
> http://hg.savannah.gnu.org/hgweb/octave/rev/51fd0cf227e4
>
> Would you like write access to the Savannah repository? I count four
> recent patches from you, all of which I applied without change, so you
> seem to know what you're doing. We can always use more help.
And another one on the way in a few minutes... Yes, thanks for the
offer, I've been using octave for years but I have taken an interest
just recently in getting more involved. Hope it doesn't wear off.
>> Is the function broken or the help text confusing?
>
> You seem confused, so I blame the help text. I personally set edit's
> HOME to "." so that files are always edited in-place or in the cwd. I
> had forgotten that this wasn't default.
So assuming my HOME is not ".", here's the section that, at least the
way I read it, says any new m-file will be put into HOME:
* If NAME.EXT is on your path then it will be edited, otherwise
the editor will be started with `HOME/name.ext' as the
filename. If `name.ext' is not modifiable, it will be copied
to `HOME' before editing.
I would fix this to say something like "otherwise the editor will be
started with `name.ext' as the filename in the current working
directory". Unless anyone else uses this feature and this is not
correct...
--
mike