octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: hist with nan's


From: fork
Subject: Re: hist with nan's
Date: Wed, 9 May 2012 22:24:48 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Muhali <muhali <at> shaw.ca> writes:


> --- hist.m    2012-05-09 11:11:55.840231862 -0700
> +++ /tmp/hist.m       2012-05-09 11:11:25.924878643 -0700
> @@ -149,7 +149,8 @@
>    if (nargin > 2 && ! ischar (varargin{iarg}))
>      ## Normalise the histogram.
>      norm = varargin{iarg++};
> -    freq = freq / rows (y) * norm;
> +    # freq = freq / rows (y) * norm;
> +    freq = freq / sum (!isnan(y)) * norm;
>    endif
> 
>    if (nargout > 0)

Shouldn't the commented code be deleted, rather than commented out, if you
really think it should be replaced? 

It is a small thing, and I am not an active contributor, but since I can't
figure out how to constructively say "Java in core? WTF?!  You can't be
serious????!!!" in another thread, I will let off a little steam here. ;)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]