Re: readline problem with gui branch ?

[Ben Abbott]

On Jun 9, 2012, at 2:40 PM, Ben Abbott wrote:

> 
> On Jun 9, 2012, at 2:27 PM, Ben Abbott wrote:
> 
>> Jacob,
>> 
>> I may be catching you in the middle of a larger change, but after the 
>> changeset below, I'm encountering an error building.
>> 
>>      http://hg.savannah.gnu.org/hgweb/octave/rev/626a8ff2fe8c
>> 
>> /Developer/usr/bin/llvm-g++-4.2 -headerpad_max_install_names -o 
>> ../bin/octave-gui octave-link.o octave-main-thread.o lexer-octave-gui.o 
>> file-editor.o file-editor-tab.o main-window.o workspace-view.o 
>> history-dockwidget.o files-dockwidget.o settings-dialog.o octave-gui.o 
>> resource-manager.o welcome-wizard.o workspace-model.o terminal-dockwidget.o 
>> octave-qt-event-listener.o moc_octave-main-thread.o moc_lexer-octave-gui.o 
>> moc_file-editor.o moc_file-editor-interface.o moc_file-editor-tab.o 
>> moc_main-window.o moc_workspace-view.o moc_history-dockwidget.o 
>> moc_files-dockwidget.o moc_settings-dialog.o moc_welcome-wizard.o 
>> moc_workspace-model.o moc_terminal-dockwidget.o 
>> moc_octave-qt-event-listener.o qrc_resource.o    
>> -L/usr/local/lib/octave/3.7.0+ -lqscintilla2 -L../qterminal/libqterminal/ 
>> -lqterminal -lm -loctinterp -loctave -lcruft -lutil -L/opt/local/lib 
>> -lQtWebKit_debug -lQtGui_debug -lQtNetwork_debug -lQtCore_debug 
>> Undefined symbols for architecture x86_64:
>> "_rl_line_buffer", referenced from:
>>     octave_event::finish_readline_event() const  in main-window.o
>> "_rl_end", referenced from:
>>     octave_event::finish_readline_event() const  in main-window.o
>> "_rl_point", referenced from:
>>     octave_event::finish_readline_event() const  in main-window.o
>> "_rl_done", referenced from:
>>     octave_event::finish_readline_event() const  in main-window.o
>> 
>> Ben
> 
> 
> Adding "-lreadline" to the LIBS variable in src/Makefile fixed the problem 
> for me.
> 
> Ben
> 

A more proper fix ?

diff --git a/gui/src/src.pro b/gui/src/src.pro
--- a/gui/src/src.pro
+++ b/gui/src/src.pro
@@ -30,7 +30,7 @@
 
 win32-msvc*: include(msvc.pri)
 
-LIBS                += -lqscintilla2  \
+LIBS                += -lreadline -lqscintilla2  \
                        -L../qterminal/libqterminal/$$LIBDIR_SUFFIX -lqterminal 
\
                         $$system(mkoctfile -p LIBS) \
                         $$system(mkoctfile -p OCTAVE_LIBS)


Ben