Re: readline problem with gui branch ?

[John W. Eaton]

On 10-Jun-2012, Jacob Dawid wrote:

| Thank you. I have added it in
| 
| http://hg.savannah.gnu.org/hgweb/octave/rev/50bf75766ac0
| 
| 
| 
|         diff --git a/gui/src/src.pro b/gui/src/src.pro
|         --- a/gui/src/src.pro
|         +++ b/gui/src/src.pro
|         @@ -30,7 +30,7 @@
| 
|          win32-msvc*: include(msvc.pri)
| 
|         -LIBS                += -lqscintilla2  \
|         +LIBS                += -lreadline -lqscintilla2  \
|                                 -L../qterminal/libqterminal/$$LIBDIR_SUFFIX
|         -lqterminal \
|                                  $$system(mkoctfile -p LIBS) \
|                                  $$system(mkoctfile -p OCTAVE_LIBS)

The only place in Octave that should be calling readline functions
directly is the command_editor class in liboctave.  If it does not
have the needed functionality for what you want to do, then we should
fix the command_editor class, not bypass it.  Maybe we should add a
command_editor::finish_event function?

jwe