octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GUI integration


From: Mike Miller
Subject: Re: GUI integration
Date: Sun, 12 Aug 2012 14:47:20 -0400

On Sun, Aug 12, 2012 at 10:03 AM, John W. Eaton wrote:
> On 12-Aug-2012, Mike Miller wrote:
>
> | Attached is a cleaned up version of the above that initializes
> | resource_manager using the Octave singleton pattern. This gets rid of
> | the segfault for me. Look good?
>
> It's better than before, yes, so please check it in.
>
> I'd prefer to be using static methods and writing
>
>   resource_manager::reload_settings ();
>
> instead of
>
>   resource_manager::instance()->reload_settings ();
>
> but I can make that change later.  At least with your change we should
> avoid the crash that is due to order of static initialization issues.

Sounds good, checked in as ad9523348676.

Your fix for no X display is also working great, no major remaining
issues for me.

-- 
mike


reply via email to

[Prev in Thread] Current Thread [Next in Thread]