Re: GCC_ATTR_DEPRECATED ?

[John W. Eaton]

On 21-Sep-2012, Ben Abbott wrote:

| > I noticed the recent change to DiagArray2.h.  Looking at the changeset I 
noticed my sources do not reflect what I see on-line.  My DiagArray2.h includes 
the snippet below.
| > 
| > 99 
| > 100   Array<T> diag (octave_idx_type k = 0) GCC_ATTR_DEPRECATED const;
| > 101   Array<T> extract_diag (octave_idx_type k = 0) const;
| > 102   DiagArray2<T> build_diag_matrix () const
| > 103   {
| > 104     return DiagArray2<T> (array_value ());
| > 105   }
| > 106 
| > 
| > While the on-line version has
| > 
| >    99 
| >   100   Array<T> diag (octave_idx_type k = 0) const;
| >   101   Array<T> extract_diag (octave_idx_type k = 0) const;
| >   102   DiagArray2<T> build_diag_matrix () const
| >   103   {
| >   104     return DiagArray2<T> (array_value ());
| >   105   }
| >   106 
| > 
| > Any idea where the "GCC_ATTR_DEPRECATED" is coming from?
| > 
| > Ben
| 
| I deleted the "GCC_ATTR_DEPRECATED"
| 
| $ hg diff
| diff --git a/liboctave/array/DiagArray2.h b/liboctave/array/DiagArray2.h
| --- a/liboctave/array/DiagArray2.h
| +++ b/liboctave/array/DiagArray2.h
| @@ -97,7 +97,7 @@
|  
|    dim_vector dims (void) const { return dim_vector (d1, d2); }
|  
| -  Array<T> diag (octave_idx_type k = 0) GCC_ATTR_DEPRECATED const;
| +  Array<T> diag (octave_idx_type k = 0) const;
|    Array<T> extract_diag (octave_idx_type k = 0) const;
|    DiagArray2<T> build_diag_matrix () const
|    {
| 
| ... and my build is now able to continue.

Jordi added this tag but it should have been after the const.  Rik
fixed it.

jwe