octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Portable sh programming in configure.ac


From: Michael Goffioul
Subject: Re: Portable sh programming in configure.ac
Date: Mon, 24 Dec 2012 23:22:33 -0500

On Mon, Dec 24, 2012 at 8:24 PM, Rik <address@hidden> wrote:
12/24/12

Michael,

In changeset 15836 you introduced double-quoted backtick expressions with
escaped double quotes (expressions of the form var="`...\"...\"...`").
According to the portable sh guidelines from Autoconf (section 11.8
http://www.gnu.org/software/autoconf/manual/autoconf.html#Shell-Substitutions)
this isn't portable.  I switched the expressions to the form
var=`..."..."...` and it works with my version of Bourne sh.  Could you
verify that the attached changeset also works with the MSYS shell?  If it
does then I will commit it.  Otherwise, we can search for a different solution.

I think it does. MSYS is using bash. I wasn't sure whether it would work without outer double-quotes, if the result produced by the backquotes includes a white space. The problem I was trying to solve is to support Java path containing space, which is typically the case on WinXP (C:\Program Files\Java\...). A large part of the configure script related to java detection does not support it, as it does not support colon in java path, though OCtJavaQry can return paths with colon (it does on my system). However I'm not affected by the latter, as the configure script assumes everything is pre-configured and does not look for java libraries or include dirs.

Please make the change, I'm confident it'll still work for me. I was just trying to be conservative.

Michael.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]