Re: QSCINTILLA and build

[Rik]

On 03/11/2013 11:32 AM, address@hidden wrote:
> Message: 9 Date: Mon, 11 Mar 2013 19:28:26 +0100 From: Torsten
> <address@hidden> To: Jordi Guti?rrez Hermoso <address@hidden> Cc:
> address@hidden Subject: Re: Build error on Ubuntu 12.10
> Message-ID: <address@hidden> Content-Type: text/plain;
> charset=UTF-8 On 11.03.2013 18:58, Jordi Guti?rrez Hermoso wrote:
>> > On 11 March 2013 13:44, Ma Xiaojun <address@hidden> wrote:
>>> >> On Tue, Mar 12, 2013 at 1:25 AM, Jordi Guti?rrez Hermoso
>>> >> <address@hidden> wrote:
>>>> >>> Can you provide a patch?
>>> >>
>>> >> No, since I have (yet) limited experience with Autotools and Octave
>>> >> codebase in general.
>> > 
>> > Yeah, we all have limited experience. Looks like you correctly figured
>> > out the problem and diagnosis despite your limited experience.
>> > 
>>> >> As I checked configure.ac, there is detection for QScintilla,
>>> >> starting from line 2604. However, line 2627-2628 looks like no
>>> >> action except displaying a warning message is taken when QScintilla
>>> >> is not found.
>> > 
>> > This warning should be rather prominent at the end of the ./configure
>> > run. Is it?
>> > 
>>> >> As I also checked generated config.h, HAVE_QSCINTILLA macro is
>>> >> correctly undefed. However, the file where the build error occurs has
>>> >> no check for such macro. (Currently no idea whether QScintilla can be
>>> >> made optional or not.)
> Could you please add
>
> #ifdef HAVE_QSCINTILLA
> #endif
>
> around line 40 of main-window.cc and build octave again. The
> main-window.cc is full of these #ifdefs around editor-code but the
> include obviously was forgotten.
3/12/13

All,

I am easily able to reproduce the original problem by removing my copy of
Qscintilla.h ('apt-get remove libqscintilla2-dev') and then re-configuring
and building.  Apparently Qscintilla is used extensively because I had to
hack a number of files to fix this.  I checked in a changeset that now
builds even when Qscintilla is not present
(http://hg.savannah.gnu.org/hgweb/octave/rev/d07aeecb2d22).  It doesn't
remove the entries for File Editor from the Windows menu, if that is a concern.

--Rik