|
From: | Daniel J Sebald |
Subject: | Re: Debugging and the GUI Editor; Qt help needed |
Date: | Thu, 28 Mar 2013 13:08:17 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Thunderbird/3.1.16 |
On 03/28/2013 02:43 AM, John W. Eaton wrote:
It would be helpful if people could test these new features. There is no need to report the problems I've listed above, but if you find other things that don't work correctly, let me know. Or if you'd just like to say, "Wow, these new features look awesome!" that would be fine too.
I haven't compiled and run yet, so I assume it looks awesome. I looked at the code, though, e.g., http://hg.savannah.gnu.org/hgweb/octave/rev/389b09a914e2and I would suggest that we try to not introduce callbacks in the way you have done. The problem with the callbacks is it is connecting two threads with functions. We should be using the Qt signal/slot mechanism across threads. Otherwise there is a good chance we're unnecessarily restricting capabilities and possibly making programming more difficult down the road.
Feel free to continue though. I have a dialog patch almost ready to go that should give an example of what I'm talking about. I'll write back in a couple days and see what we can do to remain within the signal/slot concept.
Dan
[Prev in Thread] | Current Thread | [Next in Thread] |