octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fftfilt patch


From: Jordi Gutiérrez Hermoso
Subject: Re: fftfilt patch
Date: Thu, 4 Apr 2013 16:24:46 -0400

On 4 April 2013 15:18, Daniel J Sebald <address@hidden> wrote:
> On 04/04/2013 01:30 PM, Rik wrote:

>> Do you have benchmarks for the old and new fftfilt implementation?
>> I see a for loop which is nearly always a bad thing for
>> performance.

> The for-loop you are referring to was present before the changeset.
> I was going to bring that up, but then decided it wasn't too
> critical at the moment.

Killing this loop is really easy. The all() function already works
columnwise:

    xisreal = all (imag (x) == 0);
    xisimag = all (real (x) == 0);

I don't really understand the overall algorithm or why you need these
two variables, but there you go.

- Jordi G. H.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]