Re: GUI won't build with older QScintilla

[Torsten]

On 23.04.2013 06:47, Mike Miller wrote:
> On Fri, Apr 12, 2013 at 2:41 PM, Torsten wrote:
>> For the problem with setFirstVisibleLine () I attached a simple patch
>> where the function setFirstVisibleLine () is replaced by the function
>> sendScintilla () with the message SCI_SETFIRSTVISIBLELINE as parameter.
>> Since this message is not defined in older versions I have replaced it
>> by its numeric value 2613. From a test and what I have seen in the
>> Qscintilla sources, an unknown message number is just ignored. As a
>> consequence the line where the debugger stops or which is chosen for
>> "goto line" is not centered in the editor tab.
> 
> Is this change better than adding a test to configure.ac and an ifdef
> around the call to setFirstVisibleLine? We already have similar tests
> for other Qt and Qscintilla functions, see
> OCTAVE_CHECK_FUNC_SETPLACEHOLDERTEXT and
> OCTAVE_CHECK_FUNC_FINDFIRST_MODERN.

To be honest, I am not sure.
Isn't it desirable to minimize those tests?

Torsten