|
From: | Michael Goffioul |
Subject: | Re: Special code for handling interrupts on Windows systems |
Date: | Mon, 29 Apr 2013 19:33:50 -0400 |
On Mon, Apr 1, 2013 at 1:04 AM, John W. Eaton <address@hidden> wrote:
On 03/13/2013 07:20 AM, Michael Goffioul wrote:
On Wed, Mar 13, 2013 at 2:51 AM, John W. Eaton <address@hidden<mailto:address@hidden>> wrote:
On 02/21/2013 02:35 PM, Michael Goffioul wrote:
On Thu, Feb 21, 2013 at 2:10 PM, John W. Eaton <address@hidden
<mailto:address@hidden>http://msdn.microsoft.com/en-__us/library/windows/desktop/__ms686016(v=vs.85).aspx<mailto:address@hidden <mailto:address@hidden>>> wrote:
On 02/21/2013 12:58 PM, Michael Goffioul wrote:
On Thu, Feb 21, 2013 at 12:57 PM, John W. Eaton
<address@hidden <mailto:address@hidden>
<mailto:address@hidden <mailto:address@hidden>>
<mailto:address@hidden <mailto:address@hidden>
<mailto:address@hidden <mailto:address@hidden>>>> wrote:
On 02/21/2013 12:34 PM, Michael Goffioul wrote:
I can't answer, as I don't know what part of
the code
you've
actually
disabled.
I'll do a little more testing and post a patch
that you can
try if
you'd like.
Yes, please. I'll be happy to try it out on 32bits.
OK, the patch I used is attached. I tried both 32- and
64-bit MinGW
builds. Interrupts still seem to work for me with the
command-line
and GUI builds of Octave. My test is
more off
for i = 1:100000, i, end
and then Control-C to interrupt the loop.
I love to delete unnecessary and complicated code, so I
hope that
there really is no need to have this code in Octave now.
I'll test it, but to be honest I'm surprized that it works at
all. The
Win32 API says that the default CTRL-C handler is to exit the
process
[1]. As no handler is installed anymore, I'm wondering why
octave is not
exiting when you hit CTRL-C. Did you test it in Windows or in Wine?
Michael.
[1]https://mailman.cae.wisc.edu/__pipermail/octave-maintainers/__2013-February/032218.html
<http://msdn.microsoft.com/en-us/library/windows/desktop/ms686016(v=vs.85).aspx>
Did you ever have a chance to try the patch I posted? If you
deleted the earlier mail, you can find it archived here:
<https://mailman.cae.wisc.edu/pipermail/octave-maintainers/2013-February/032218.html>
No, sorry, I didn't get a chance to try it. I'll do my best to give it a
try in the coming days.
I went ahead and made the changes and pushed them to savannah. Interrupts seem to be working fine for me with the MinGW builds I'm doing. Exiting Octave with quit or by clicking the [x] window button also seems to work now without crashing Octave and generating an "Octave is not responding" dialog box.
If you notice problems after updating, then let's discuss.
jwe
My apologies for not answering, I just didn't find the time to try it out. You made the right move, though, it cannot be worse than what it was anyway :).
[Prev in Thread] | Current Thread | [Next in Thread] |