octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Question about Array::index with resizing


From: John W. Eaton
Subject: Re: Question about Array::index with resizing
Date: Thu, 23 May 2013 01:31:56 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121122 Icedove/10.0.11

On 05/23/2013 01:15 AM, John W. Eaton wrote:
On 05/23/2013 12:39 AM, John W. Eaton wrote:

I can't see where these functions are actually used with resize_ok =
true. If that's actually the case, then I'd be happy to remove these
arguments.

I did some more digging and I do see that it is used in ov-class.cc, at
least.

Also through the "auto_add" parameter of the octave_value::subsref that was apparently added by Jaroslav. That's set to true in one case in tree_index_expression::lvalue.

Given the comments in Array.h:

  // Indexing with possible resizing and fill
  // FIXME -- this is really a corner case, that should better be
  // handled directly in liboctinterp.

maybe we should fix libinterp now so that it handles the special cases and eliminate them from the Array class index functions?

jwe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]