Re: Google Summer of Code - LaTeX processing

[Michael Goffioul]

On Wed, Jun 19, 2013 at 5:53 AM, Andrej Lojdl <address@hidden> wrote:

2013/6/19 Michael Goffioul <address@hidden>

If you have problems, you should ask for help. Don't be shy. Could you provide a full changeset, so that we can have the full picture.

Michael.

I've modified two line mentioned > txt-eng-ft.cc :

yoffset -= (line_height + (face->size->metrics.height >> 6));

 and

bbox(1) -= (line_height + (face->size->metrics.height >> 6));

And added these seven lines > graphics.in.h

 double_property line_height u , 0 (after 3817)

 void update_line_height (void) { update_font (); } (after 3965)

 double_property line_height u , 0 (after 4276)

 void update_line_height (void) { update_font (); update_text_extent (); } (after 4369)

 double_property line_height u , 0 (after 4999)

 void update_line_height (void) { update_text_extent (); }  (after 5036)

 double_property line_height , 0  (after 5086)

Line numbers are original. If there is an easier and more compact way to send changeset, please tell me.

Please, try to produce proper patches using "hg diff". In the above code, I don't see anything that will pass the line_height value down to text engine. By comparison, you should follow how it's done for the fontsize:

1) extend ft_render::set_font() method with a "lineheight" argument

2) populate that new argument in opengl_renderer::set_font() method

Also, don't use "line_height", but "lineheight" for the property name, to be consistent with the rest of the property names. And I think it's better  to make lineheight a scaling factor rather than an absolute offset. In the latter case, it would then be more appropriate to make lineheight sensitive to the "units" property, but I don't want to go down that road.

Michael.