Re: Commit message guidelines

[Catalin Codreanu]

2013/6/27 Jordi Gutiérrez Hermoso <address@hidden>

On 27 June 2013 09:49, Catalin Codreanu <address@hidden> wrote:
>
> 2013/6/27 Jordi Gutiérrez Hermoso <address@hidden>
>>
>> On 27 June 2013 09:31, Catalin Codreanu <address@hidden>
>> wrote:
>> > Also, I wanted to point out that in some messages filenames are enclosed
>> > in
>> > ' ... ', or " ... " while in others they are not. Should we standardize
>> > this
>>
>> I'm not sure what you mean. Where are you seeing this? Look at "hg log
>> -v" for examples of the commit messages we would like.
>
>

> For example, in "file_editor_tab",
> there is this message : Could not open file %1 for write:\n%2.
>
> and also this message : It seems that '%1' has been modified by another
> application. Do you want to reload it?
>
> The %1 is a placeholder for the file name which is not enclosed in
> apostrophes in the first case.

Oh, I thought you were referring to commit messages.

In the GUI, I think filenames should be in a different and clearly
differentiated font. If this isn't feasible, I would prefer if they
were quoted. But I don't know anything about UX, so take my preference
with a grain of salt.

- Jordi G. H.

AFAIK, Qt allows for HTML style formatting in texts :

This is a file : <b>~/.hgrc</b>

shows the filename in bold :

This is a file : ~/.hgrc

Perhaps we can choose a style and stick with it.

Cat