Re: Adding new OF packages to mxe-octave

[Anirudha Bose]

On Sun, Jul 28, 2013 at 8:01 PM, Michael Goffioul <address@hidden> wrote:

On Sun, Jul 28, 2013 at 6:04 AM, Anirudha Bose <address@hidden> wrote:

2) I noticed the warning about Win8; did you try the gnulib patch that solves the problem? it might be good to integrate it into the octave patch in MXE, until it's ported upstream; alternatively you could modify the installer to add "-i --line-editing" to the octave command in the start menu links

The gnulib patch doesn't work. The GUI still doesn't load when octave.exe is executed on Windows 8. I have tested this on other systems too.

Weird, this should have worked. Could you provide the patch (against octave sources) that you applied?

I have attached a patch. The patch doesn't work for Windows 8, and apparently it is causing the same problems in other versions of Windows too. But that is only if I have made the changes correctly. If I revert back to the macro IsConsoleHandle, Octave GUI works fine (except in Windows 8).

 

The "-i --line-editing" trick is able to bring the prompt octave.exe:1> which was missing earlier. However, it doesn't solve the GUI problem.

True. To have the GUI working, "isatty" needs to return "true". 

 

3) you re-used the graphics from my installer; these are quite ancient and based on a logo proposal that was made a couple of years ago, before the current octave logo; the installer graphics should be based on the current octave logo; I'm not asking you to create the graphics, the current logo was created by address@hidden (IIRC), maybe you could ask him to make graphics for the installer?

Does it mean that the header images and welcome/finish page images should have the present Octave logo?

Yes. The graphics that you used do not really correspond to the current octave "image/trademark".

I have attached a new graphics which I think corresponds to the current Octave trademark. Is it acceptable?

Michael.

- Anirudha

isatty.patch
Description: Binary data

octave-side.bmp
Description: Windows bitmap