octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libgui/src/resource-manager.cc contains removed function names. Shou


From: Andreas Weber
Subject: Re: libgui/src/resource-manager.cc contains removed function names. Should we remove them?
Date: Sun, 15 Sep 2013 21:17:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130827 Icedove/17.0.8

Am 15.09.2013 16:50, schrieb John W. Eaton:
> On 09/15/2013 07:56 AM, Andreas Weber wrote:
>> Dear octave maintainers,
>> I'm currently searching and removing references to already removed
>> functions and stumbled over resource-manager.cc.
>> ...
>> Can I remove the "removed functions" from resource-manager.cc or is
>> there a reason to keep them there?
> 
> This list should really not be static.  There are functions in Octave
> that return lists of keyword and function names that should be used
> instead to build the list.  I've been meaning to fix this but just
> haven't gotten around to doing it.

Dear John,

I can't find any use of octave_keywords in default.

The last call I found was in 4258750c76ed:
libgui/src/resource-manager.h:84:  static const char *octave_keywords
(void);
libgui/src/resource-manager.cc:226:resource_manager::octave_keywords (void)
libgui/src/m-editor/lexer-octave-gui.cc:180:      return
resource_manager::octave_keywords ();

but this was removed with 025bc6b5080e. So as I can see we can savely
remove "const char* resource_manager::octave_keywords".

Regards, Andy


reply via email to

[Prev in Thread] Current Thread [Next in Thread]