|
From: | John W. Eaton |
Subject: | Re: member variables needed in curl wrapper class |
Date: | Tue, 08 Oct 2013 09:51:41 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 |
On 10/08/2013 07:24 AM, Mike Miller wrote:
John, I noticed your recent changes to the url handling code backed out a change I had made some months ago: http://hg.savannah.gnu.org/hgweb/octave/rev/81fe6665ed3c I plan to essentially reapply this patch to the new base class. Should I add a comment to the member variable declaration explaining why they should be stored in the class?
Thanks for catching this. Fixed here: http://hg.savannah.gnu.org/hgweb/octave/rev/9e507e30c9eaMaybe the text from the bug report that I added as a comment for the userpwd variable will help prevent making this mistake again.
jwe
[Prev in Thread] | Current Thread | [Next in Thread] |