[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: converting string between gui widgets and octave
From: |
John W. Eaton |
Subject: |
Re: converting string between gui widgets and octave |
Date: |
Sat, 12 Oct 2013 09:02:30 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 |
On 10/12/2013 03:18 AM, Torsten wrote:
Some months ago I added changesets for converting strings into the
correct charsets between gui widgets like history/file browser and
octave itself. These conversions have disappeared leading to bug #40239.
One changeset where the conversion was removed (in that case for the
octave directory) seems to be 919796a440c6:
http://hg.savannah.gnu.org/hgweb/octave/rev/919796a440c6#l4.37
http://hg.savannah.gnu.org/hgweb/octave/rev/919796a440c6#l4.58
Was this intended?
I removed the call to toUtf8 because I wasn't sure why it was needed
and we don't use it anywhere else in Octave. Everything else is just
using toStdString.
If that was a mistake, then please revert it, but can you also please
explain when and why we should be using toUtf8? I believe that Matlab
uses 16-bit characters, so for compatibility Octave will probably have
to support some kind of wide characters in the future. Will we have
to change this again?
jwe