Re: CSparse seg fault

[Rik]

On 10/18/2013 06:30 AM, address@hidden wrote:
> Message: 3
> Date: Fri, 18 Oct 2013 09:11:00 +0200
> From: David Bateman <address@hidden>
> To: Mike Miller <address@hidden>,     "Dmitri A. Sergatskov"
>       <address@hidden>
> Cc: David Bateman <address@hidden>,   Octave Maintainers
>       <address@hidden>
> Subject: Re: CSparse seg fault
> Message-ID: <address@hidden>
> Content-Type: text/plain; charset=UTF-8
>
> On 10/18/2013 03:28 AM, Mike Miller wrote:
>> > On Thu, Oct 17, 2013 at 20:12:01 -0500, Dmitri A. Sergatskov wrote:
>>> >> changeset:   17682:93e272018df2
>>> >> tag:         tip
>>> >> user:        David Bateman <address@hidden>
>>> >> date:        Fri Oct 18 01:36:31 2013 +0200
>>> >> summary:     Correct dimesion of return values form sparse min/max 
>>> >> function
>>> >> with empty
>>> >>
>>> >> might have a problem:
>>> >>
>>> >> running "make check"
>>> >> ...
>>> >>  libinterp/parse-tree/pt-mat.cc-tst ..................... PASS  199/199
>>> >>   libinterp/octave.cc-tst ................................ PASS    8/8
>>> >>   liboctave/array/Array.cc-tst ........................... PASS   18/18
>>> >>   liboctave/array/CMatrix.cc-tst ......................... PASS   11/11
>>> >>   liboctave/array/CSparse.cc-tst .........................panic:
>>> >> Segmentation fault -- stopping myself...
>>> >> make[1]: *** [check] Segmentation fault
>> > Yep, failing on our continuous build as well, e.g.
>> >
>> >   http://hydra.nixos.org/build/6505321/log/tail-reload
>> >
> The problem seems to be independant of the change I made, just that
> adding the assert
>
> assert ( max (max (sparse (66536) * 1i)), sparse (1i))
>
> seems to have exposed another bug, this fails even for
>
> assert ( max (max (sparse (10) * 1i)), sparse (1i))
>
> and apparently without the changes I made. I can't look at this any lore
> till tonight or tomorrow. If this is really a problem I'd suggest remove
> the assert statements from CSparse.cc till I can look at till

David,

The new sparse code is not to blame.  I can run each of the individual
statements and they work fine.  Something is wrong with assert, which I am
investigating.

Sample code

assert (sparse (2i), sparse (1i))
--> segfault

--Rik